DSDHacked [SOUNDS] support #1
Conversation
cmbernard333
force-pushed
the
feature/dsdhacked-2021
branch
from
0ba5c12 to
ed0fec4
Compare
electricbrass
force-pushed
the
dsdhacked-sound
branch
from
c2b11e5 to
372ae41
Compare
| { | ||
| for (int i = 0; i < count; i++) | ||
| { | ||
| SoundMap.insert(source[i] ? strdup(source[i]) : NULL, i); |
There was a problem hiding this comment.
According to the id24spec, sfx has a soundnum that is int32_t. We should add those for all sounds if possible so we can reference them directly by index. This is similar to how mobjinfo and state_t have their own indices.
There was a problem hiding this comment.
Though looking at PatchSounds DoomObjectContainer does have the ability to store and find the given index that a sound is stored with. Does this map resolve to an sfx struct somewhere?
There was a problem hiding this comment.
yes, the sound structs are stored in S_sfx, a vector that is mostly only modified and accessed by functions from s_sound.cpp
There was a problem hiding this comment.
Making a note here (not necessary to implement right now): the struct channel_t in s_sound.cpp is similar to the id24spec struct sfxinfo_s. That's where we can do id24 work later on.
electricbrass
force-pushed
the
dsdhacked-sound
branch
from
8ef71b8 to
8a0f7e6
Compare
|
Don't want to merge this yet, it's causing some issues with multiplayer in eviternity 2. |
Fixed, soundmap wasn't being initialized on the server. |
cmbernard333
merged commit f34a445
into
cmbernard333:feature/dsdhacked-2021
Implement PatchSounds for DSDHacked.